[Rpm-maint] [rpm-software-management/rpm] Try telling cmake that the project needs to be built before testing (… (PR #2357)

Panu Matilainen notifications at github.com
Tue Jan 17 10:30:50 UTC 2023


…#2356)

Recently there have been a fair amount of random failures in the CI, due to apparent ordering errors / lack of dependencies that have been hard to reproduce locally. The key is probably CI running "make check" right away, which then proceeds on all the relevant targets in parallel. And nowhere at all we're telling it that the tests need the entire project to be already built. So apparently the "make install" in tests/populate often ends up building a significant part of the project and ... that two competing makes in the tree ever actually manage to complete at all is a small miracle.

Make populate_testing target depend on top-level cli utils to enforce at least "mostly sane" situation when running "make check" without a preceeding build. This should address the issue of random CI failures.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2357

-- Commit Summary --

  * Try telling cmake that the project needs to be built before testing (#2356)

-- File Changes --

    M tests/CMakeLists.txt (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2357.patch
https://github.com/rpm-software-management/rpm/pull/2357.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2357
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2357 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230117/a4fca1c2/attachment.html>


More information about the Rpm-maint mailing list