[Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume III (PR #2568)

Michal Domonkos notifications at github.com
Fri Jul 7 06:08:51 UTC 2023


@dmnks commented on this pull request.



>          RPM_CONFIGDIR=${RPMTEST}/@RPM_CONFIGDIR@
-        export RPMTEST HOME RPM_CONFIGDIR
+        export RPMTEST RPM_CONFIGDIR

Oh-oh, again, you're right. On one hand, we do override a bunch of paths like `_topdir` in `run()` but you can never be sure that some program/script in the whole chain won't actually look at `$HOME`.

Us overriding it here for fakechroot is basically the poor-man's containerization that we're getting rid of, so while it's not a problem when you run the whole thing in a container, we're not there *yet* with this PR, so better leave that out, indeed.

And yup, it was a cleanup change, no other reason, really :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#discussion_r1255288562
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2568/review/1517986454 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230706/8a57811f/attachment.html>


More information about the Rpm-maint mailing list