[Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume III (PR #2568)

[Panu Matilainen]

@pmatilai commented on this pull request.



>      fi
 }
 
 function sandbox()
 {
-    (unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
-     cd ${RPMTEST} && \
-     FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-    )
+    local cmd=$1
+    shift
+    case $cmd in
+        exec)
+            (unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
+             cd ${RPMTEST} && \

That said, lets not make this an "oh no, stop ship" situation. Missing quotes only affect marginal use-cases (in my books, using spaces in development directory names equal shooting your own foot just to be sure). So don't go chasing every unquoted variable now, it's not a show-stopper at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#discussion_r1255296683
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2568/review/1518005880 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230706/c79984ea/attachment.html>