[Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

[Neal Gompa]

@Conan-Kudo requested changes on this pull request.

Looks like this isn't working exactly:

>From CI:

```
[ 73%] Building C object CMakeFiles/rpmuncompress.dir/tools/rpmuncompress.c.o

/srv/rpm/tools/rpmuncompress.c: In function 'doUntar':

/srv/rpm/tools/rpmuncompress.c:101:39: error: passing argument 1 of '__xpg_basename' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]

  101 |             const char *bn = basename(fn);

      |                                       ^~

In file included from /srv/rpm/tools/rpmuncompress.c:4:

/usr/include/libgen.h:34:36: note: expected 'char *' but argument is of type 'const char *'

   34 | extern char *__xpg_basename (char *__path) __THROW;

      |                              ~~~~~~^~~~~~
cc1: all warnings being treated as errors

make[3]: *** [CMakeFiles/rpmuncompress.dir/build.make:76: CMakeFiles/rpmuncompress.dir/tools/rpmuncompress.c.o] Error 1

make[2]: *** [CMakeFiles/Makefile2:703: CMakeFiles/rpmuncompress.dir/all] Error 2
```



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2571#pullrequestreview-1526023267
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2571/review/1526023267 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230712/19d7a1c8/attachment.html>