[Rpm-maint] [rpm-software-management/rpm] Mount the common tree snapshot as read-only (PR #2583)

[Michal Domonkos]

This ensures no single test can (accidentally or intentionally) alter the shared tree and influence the subsequent tests.

This also makes us comply with the following OverlayFS requirement which could otherwise be violated when running parallel tests:

    Changes to the underlying filesystems while part of a mounted
    overlay filesystem are not allowed. If the underlying filesystem is
    changed, the behavior of the overlay is undefined, though it will
    not result in a crash or deadlock.

Contrary to what I thought in commit
    cf8716f204f1eed196ca7ae905288261e0c88c3b,
to make this work, all we need is to mount a new tmpfs at /tmp in the snapshot, as that's where some of the processes (patch(1) in particular) need to write.

Update the comment in mktree.rootfs accordingly, too.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2583

-- Commit Summary --

  * Mount the common tree snapshot as read-only

-- File Changes --

    M tests/mktree.native (4)
    M tests/mktree.podman (5)
    M tests/mktree.rootfs (7)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2583.patch
https://github.com/rpm-software-management/rpm/pull/2583.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2583
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2583 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230725/951f7b22/attachment.html>