[Rpm-maint] [rpm-software-management/rpm] Check inside --root when querying for files (PR #2582)
Michal Domonkos
notifications at github.com
Wed Jul 26 13:03:39 UTC 2023
@dmnks commented on this pull request.
> @@ -470,11 +470,13 @@ static rpmdbMatchIterator initQueryIterator(QVA_t qva, rpmts ts, const char * ar
if (mi == NULL) {
struct stat sb;
- if (lstat(fn, &sb) != 0)
+ char * full_fn = rpmGenPath(rpmtsRootDir(ts), fn, NULL);
How about using the simpler `rpmGetPath()` instead? The Gen variant only differs in that it also accepts URLs which I don't think we need here :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2582#pullrequestreview-1547683591
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2582/review/1547683591 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230726/c4f89eda/attachment.html>
More information about the Rpm-maint
mailing list