[Rpm-maint] [rpm-software-management/rpm] Allow setting platform macro settings externally (PR #2585)

[Neal Gompa]

@Conan-Kudo requested changes on this pull request.



> +This is enough for regular Linux distributions, except Yocto. Yocto has
+so called Board Support Packages (BSPs) that cover more than the CPU
+architectures. These BSPs cover specific single board computer systems.
+Examples of such BSP names:

Can you reword this to not require knowing what Yocto is? That is, if Yocto disappeared tomorrow, we wouldn't have a good reference for the need for this feature.

While we want to serve and support distributions, we try to ensure our features aren't "distro-dependant", so if the documentation on this can be made compelling without singling out or requiring to know Yocto, that would significantly help.

> +This is enough for regular Linux distributions, except Yocto. Yocto has
+so called Board Support Packages (BSPs) that cover more than the CPU
+architectures. These BSPs cover specific single board computer systems.
+Examples of such BSP names:

Can you reword this to not require knowing what Yocto is? That is, if Yocto disappeared tomorrow, we wouldn't have a good reference for the need for this feature.

While we want to serve and support distributions, we try to ensure our features aren't "distro-dependant", so if the documentation on this can be made compelling without singling out or requiring to know Yocto, that would significantly help.

> +To allow creating the macros file for such a custom platform (only one
+needed for a specific BSP build in Yocto), the shell variables listed below
+must be set. If RPM_CUSTOM_ARCH is not set, the rest is ignored.

Ditto here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2585#pullrequestreview-1547729808
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2585/review/1547729808 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230726/adcf477d/attachment.html>