[Rpm-maint] [rpm-software-management/rpm] Fix rpmlog() getting called after forking in signing code (PR #2422)

Panu Matilainen notifications at github.com
Thu Mar 9 09:22:54 UTC 2023


Calling rpmlog() after fork is undefined behavior because of the locking it does, and non-sensical as well, as any warnings and errors it catches end up in the wrong process. Just print to stderr instead, and improve the messages while at it: handle possible popt parse error separately, and print the real name of the program whose exec failed.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2422

-- Commit Summary --

  * Fix rpmlog() getting called after forking in signing code

-- File Changes --

    M sign/rpmgensig.c (11)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2422.patch
https://github.com/rpm-software-management/rpm/pull/2422.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2422
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2422 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230309/feea5863/attachment.html>


More information about the Rpm-maint mailing list