[Rpm-maint] [rpm-software-management/rpm] Populate user and group data in cpio payload again (PR #2430)

Panu Matilainen notifications at github.com
Thu Mar 16 09:51:10 UTC 2023


In general, rpm populates the cpio header with the same info as the file lists in the header, although it only uses the latter. This is even documented in LSB (up to and including version 5). At some point, the user and group information has gotten dropped though, all files end up owned by root:root according to the cpio header.

The roots of that change go deeper than I care to dig, but I've noted this behavior in commit fc36f322e123a7421b798f12358cc701e28afbe0 already. The actual change has happened earlier, possibly 8b7b911a17f187822f6e72b162ef3bea39366176 but it's impossible to test stuff that old.

While the cpio format is on its way out, packages built with current rpm versions will live long into the future so we might as well fix this, I see no reason not to. Add a test as well.

Payload digest changes, causing all the other hashes to change too.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2430

-- Commit Summary --

  * Populate user and group data in cpio payload again

-- File Changes --

    M build/files.c (3)
    M tests/rpmbuild.at (30)
    M tests/rpmsigdig.at (10)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2430.patch
https://github.com/rpm-software-management/rpm/pull/2430.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2430
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2430 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230316/41a4c684/attachment.html>


More information about the Rpm-maint mailing list