[Rpm-maint] [rpm-software-management/rpm] Make user/group info reliable operation across chroot (PR #2503)

Panu Matilainen notifications at github.com
Tue May 9 14:04:01 UTC 2023


@pmatilai commented on this pull request.



>  #include <rpm/rpmlog.h>
 #include <rpm/rpmstring.h>
 
 #include "lib/misc.h"
 #include "lib/rpmug.h"
 #include "debug.h"
 
+#define PWFILE "/etc/passwd"
+#define GRPFILE "/etc/group"

I wondered about this too. If there's a remotely relevant OS that has those files in some other location or some other use-case, I'd like to hear. That said, an "obvious" use-case for overrides is testing, and that may well be enough of a reason to do support it.

Oh and thanks for the review!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#discussion_r1188654007
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2503/review/1418719719 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230509/077c77ea/attachment.html>


More information about the Rpm-maint mailing list