[Rpm-maint] [rpm-software-management/rpm] Make user/group info reliable operation across chroot (PR #2503)

[David Cantrell]

@dcantrell commented on this pull request.



>  #include <rpm/rpmlog.h>
 #include <rpm/rpmstring.h>
 
 #include "lib/misc.h"
 #include "lib/rpmug.h"
 #include "debug.h"
 
+#define PWFILE "/etc/passwd"
+#define GRPFILE "/etc/group"

I would say testing is the most relevant use here to define these paths in a config file.  In current practice, I think the only relevant systems that have a different path for this file are BSD systems with /etc/master.passwd.  But even still I think they provide /etc/passwd for compatibility.

Still this one strikes me as the kind of thing that systemd or some project like that would go and change and then rpm would get blamed when things break.

(And np on the review)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#discussion_r1189853254
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2503/review/1420555247 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230510/e924eb43/attachment.html>