[Rpm-maint] [rpm-software-management/rpm] Make user/group info reliable operation across chroot (PR #2503)

[David Cantrell]

@dcantrell commented on this pull request.



> +	    }
+	}
+    }
+
+    fclose(f);
+
+    return rc;
+}
+
+static int lookup_num(const char *path, const char *val, int vcol, int rcol,
+			long *ret)
+{
+    char *buf = NULL;
+    int rc = lookup_field(path, val, vcol, rcol, &buf);
+    if (rc == 0) {
+	long num = atol(buf);

Oh I've been there.  I will definitely add error checking later.  :)

This one stood out to me because of the 0 returned for errors which would be UID or GID 0.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#discussion_r1189854210
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2503/review/1420556704 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230510/177b24e6/attachment-0001.html>