[Rpm-maint] [rpm-software-management/rpm] Make user/group info reliable operation across chroot (PR #2503)

[David Cantrell]

@dcantrell commented on this pull request.



> +			long *ret)
+{
+    char *buf = NULL;
+    int rc = lookup_field(path, val, vcol, rcol, &buf);
+    if (rc == 0) {
+	long num = atol(buf);
+	*ret = num;
+	free(buf);
+    }
+    return rc;
+}
+
+static int lookup_name(const char *path, long val, int vcol, int rcol,
+			char **ret)
+{
+    char vbuf[256];

I thought about asprintf() but that's not portable.  rasprintf() would work.  Honestly, even though it's silly I say use rasprintf().  Static buffers always lead to future problems, at least in my experience.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#discussion_r1189856745
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2503/review/1420560604 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230510/5b49d138/attachment.html>