[Rpm-maint] [rpm-software-management/rpm] Make user/group info reliable operation across chroot (PR #2503)

Panu Matilainen notifications at github.com
Wed May 10 12:47:40 UTC 2023


@pmatilai commented on this pull request.



> +			long *ret)
+{
+    char *buf = NULL;
+    int rc = lookup_field(path, val, vcol, rcol, &buf);
+    if (rc == 0) {
+	long num = atol(buf);
+	*ret = num;
+	free(buf);
+    }
+    return rc;
+}
+
+static int lookup_name(const char *path, long val, int vcol, int rcol,
+			char **ret)
+{
+    char vbuf[256];

Yup. It's totally ridiculous how strong that "don't want to waste a malloc on this" feeling is, when in the context it's absolutely nothing at all :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#discussion_r1189859848
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2503/review/1420565197 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230510/99a8849d/attachment.html>


More information about the Rpm-maint mailing list