[Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

[Tomasz Kłoczko]

> Look, there simply are no references to those symbols in the entire source tree. Take a pristine copy of the source and see for yourself. I don't know what you're building, but those error messages can not come from building the pristine 4.19 alpha tarball or git master.

Are you sure?
````console
[tkloczko at pers-jacek rpm-4.18.90]$ grep -r pgpPrtPkts
include/rpm/rpmpgp.h:int pgpPrtPkts(const uint8_t *pkts, size_t pktlen, pgpDig dig, int printing);
rpmio/rpmkeyring.c:     pgpPrtPkts(key->pkt, key->pktlen, sig, _print_pkts);
rpmio/rpmkeyring.c:    rc = pgpPrtPkts(key->pkt, key->pktlen, dig, _print_pkts);
rpmio/rpmpgp_sequoia.c:W(int, pgpPrtPkts,
ChangeLog:    - pgpPrtPkts() is basically just a wrapper to pgpPrtParams()
ChangeLog:    Clean up pgpPrtPkts() and friends a bit
ChangeLog:    - Since the only entry to these is pgpPrtPkts() and that ensures
ChangeLog:    Added sanity checks on pgpPrtPkts() entry
ChangeLog:      early on in pgpPrtPkts() and doesn't change, and the rsa/dsa
ChangeLog:      pgpPrtPkts() to validate & figure it out and check its return code instead,
ChangeLog:    - The error message is not very helpful but if pgpPrtPkts() fails
ChangeLog:    Oops, rpmPubkeyDig() should return NULL if pgpPrtPkts() fails
ChangeLog:    Actually handle headerGet() / pgpPrtPkts() failure on signature verify
ChangeLog:    - additionally verify pgpPrtPkts() return code
```
Tar ball taken from http://ftp.rpm.org/releases/testing/rpm-4.18.90.tar.bz2


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1563231113
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/2507/1563231113 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230525/c2dd0941/attachment-0001.html>