[Rpm-maint] [rpm-software-management/rpm] Revert %_smp_build_ncpus change to a parametric macro (RhBug:2210347) (PR #2524)

Panu Matilainen notifications at github.com
Mon May 29 07:47:11 UTC 2023


Commit a213101bc3af65c860d045c65fb4e2ef7566a4c6 changed %_smp_build_ncpus into a parametric macro, but this breaks common usage via the Lua macros table as parametric macros are returned as closures rather than the expanded value.

This seems like a design flaw of the macros table, but as an immediate remedy for the breakage, add another layer of indirection to revert %_smp_build_ncpus back to a non-parametric macro.

Fixes %constrain_build macro in Fedora, which ironically is made obsolete by the change that (unintentionally) broke it.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2524

-- Commit Summary --

  * Revert %_smp_build_ncpus change to a parametric macro (RhBug:2210347)

-- File Changes --

    M macros.in (12)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2524.patch
https://github.com/rpm-software-management/rpm/pull/2524.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2524
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2524 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230529/c9fcffc7/attachment.html>


More information about the Rpm-maint mailing list