[Rpm-maint] [rpm-software-management/rpm] Implement a declarative autobuild system (prototype) (PR #2620)

Panu Matilainen notifications at github.com
Wed Nov 1 07:24:10 UTC 2023


@pmatilai commented on this pull request.



> @@ -1349,5 +1349,14 @@ end
     end
 }
 
+# example autobuild macros for autotools
+%autobuild_autotools_prep() %autosetup -p1

Sure, the %prep part is here more for demo purposes than something we'd want to ship for real. Instead we should probably just automatically add "%autosetup -p1" %prep section to *everything* that has sources and does not have a prep. I don't understand the remark about %build -a though. If you need to do pre-build shenanigans, you do it in one %prep -a for the earliest opportunity, or in %conf -p/-a or %build -p, as appropriate.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2620#discussion_r1378469441
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2620/review/1707694521 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231101/ee0e3666/attachment.html>


More information about the Rpm-maint mailing list