[Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)

Panu Matilainen notifications at github.com
Wed Oct 4 07:22:56 UTC 2023


@pmatilai commented on this pull request.



> @@ -1,6 +1,4 @@
-# Use our top-level targets as an ordering clue to cmake: the project
-# needs to be built before we can populate anything...
-get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS)
+set(RPM_TARGETS librpm librpmio librpmbuild librpmsign)

After a brief wtf moment, I see that I broke the top level target fetch in commit 86d99a1d20bbebfeb4427c99b1bb1053029c3317. Oof. 

But this is a fine example of what should've gone into a separate PR as soon as noticed because this has nothing to do with the change in *this* PR. I'll fix since it's me who broke it in the first place.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2691#pullrequestreview-1656827186
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2691/review/1656827186 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231004/b29b3954/attachment.html>


More information about the Rpm-maint mailing list