[Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)

Michal Domonkos notifications at github.com
Wed Oct 4 07:31:05 UTC 2023


@dmnks commented on this pull request.



> @@ -1,6 +1,4 @@
-# Use our top-level targets as an ordering clue to cmake: the project
-# needs to be built before we can populate anything...
-get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS)
+set(RPM_TARGETS librpm librpmio librpmbuild librpmsign)

Oh, this explains that little mystery of "why on earth doesn't this TOP_TARGETS work for me as expected" :smile: I actually settled on that having been broken from the start and just patched it quickly this way, with the thought of investigating a bit more afterwards. And yes, this would've gone to a separate commit in this PR as well :smile: 

So yup, feel free to fix, I'll then just rebase. Thanks :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345326049
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2691/review/1656840736 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231004/529368b0/attachment.html>


More information about the Rpm-maint mailing list