[Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

Vít Ondruch notifications at github.com
Fri Oct 20 10:17:28 UTC 2023


@voxik commented on this pull request.



> @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main package.
 Package build is divided into multiple separate steps, each executed
 in a separate shell.
 
+Only one of each section can be present in a spec, but all build scriptlets
+except for `%prep` accept options `-a` and `-p`, for append and prepend mode.
+Append and prepend append or prepend lines to the section in the order they
+appear in the spec. Both append and prepend can be used multiple times and
+without other restrictions, but a section without either mode can only
+appear first (eg `%build` cannot follow `%build -p`).

This feels artificial to me.

Not mentioning that the attached test case does not contain `%install` section as far as I can see. So how it is supposed to work in this case?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2728#pullrequestreview-1689709351
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2728/review/1689709351 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231020/8edd3fc3/attachment.html>


More information about the Rpm-maint mailing list