[Rpm-maint] [rpm-software-management/rpm] Standardize on OCI images in test-suite (PR #2733)
Michal Domonkos
notifications at github.com
Thu Oct 26 07:58:01 UTC 2023
> Hmm. I'm getting a LOT of failures when running this as "make check" locally on F38, before and after doing an 'rm -rf *' of the entire build tree:
Ugh, I haven't tested the non-default (`/usr/local`) prefix... *This* is why PRs are actually valuable, it seems like :sweat_smile: Of course it *has to* work with any prefix, that was the requirement from the start (and seems like the current Fedora backend does work). I'll have a look, thanks!
> Another random observation: mktree.docker seems to be suffering from a minor schizophrenia, because it mostly talks about Podman inside 😅 Maybe it should be mktree.oci instead?
The symlink really is meant as just a silly "shortcut" for something like (in the CI):
```
USE_DOCKER=1
./mktree.podman ...
```
But I agree, `mktree.oci` was also on my mind, it's perhaps more "correct" as it says "make an OCI-based test tree" (much like e.g. the `mkfs.*` binaries). Let me change it then :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2733#issuecomment-1780603712
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2733/c1780603712 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231026/f6e329b1/attachment.html>
More information about the Rpm-maint
mailing list