[Rpm-maint] [rpm-software-management/rpm] Exit from mktree on failure (PR #2740)

[Michal Domonkos]

Right now, if the podman image fails to build or rpm fails to build/install, we happily continue and run the test-suite, only to eventually fail with some cryptic error, such as:

    error: cannot find rpm

Not too helpful, indeed.  Instead, just fail the whole tree preparation process if we encounter an error.

Fix the return code of unshared() so that we don't fail on that, though. Also, when building the RPM layer, use a proper cleanup trap instead of ignoring SIGINT since a failing make_install() can now terminate the script.

Fixes: #2667
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2740

-- Commit Summary --

  * Exit from mktree on failure

-- File Changes --

    M tests/mktree.oci (7)
    M tests/mktree.rootfs (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2740.patch
https://github.com/rpm-software-management/rpm/pull/2740.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2740
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2740 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20231031/be226ae6/attachment.html>