[Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

Panu Matilainen notifications at github.com
Tue Sep 5 11:09:22 UTC 2023


@pmatilai requested changes on this pull request.

Eek. I can see why you want to do something like this, but this kind of mega-patch that is hard to review and totally unbisectable.

Split it into more commits. For things that just move but don't actually change, temporarily change them to non-static with prototypes in rpmbuild_internal.h. Then do the actual change, which becomes actually revievable now, and finally do the actual move of the those unchanged helpers in a commit that only moves and doesn't change.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2646#pullrequestreview-1610800180
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2646/review/1610800180 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230905/59b360a2/attachment.html>


More information about the Rpm-maint mailing list