[Rpm-maint] [rpm-software-management/rpm] Fix tagtbl.C placement in build dir (PR #2670)

[Michal Domonkos]

We actually [include](https://github.com/rpm-software-management/rpm/blob/58021924994db8949247cf99883695ce12e4d73b/CMakeLists.txt#L371) the top-level build directory in the top-level CMakeLists file, it even says `# generated sources` in a comment. So that could've been the impulse for you to output it there so that you didn't need to add the current build dir into the new include list in `lib/CMakeLists.txt`, I suppose.

At first, I thought the fix would be just to use `OUTPUT ${CMAKE_BINARY_DIR}/tagtbl.C`, however that turned out wrong because we link librpm against that file (further up) and since it doesn't exist in the source dir, cmake tries to find it in the binary dir, and failing that, tries to find a target that builds it - which is this one. So putting a prefix such as `${CMAKE_BINARY_DIR}` to it would cause cmake to *not* find it, and fail :smile:

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2670#issuecomment-1733428364
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2670/c1733428364 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230925/836f31ac/attachment.html>