[Rpm-maint] [rpm-software-management/rpm] Ensure source headers are identified as such after a spec parse (PR #3012)

[Panu Matilainen]

headerIsSource() uses RPMTAG_SOURCERPM presence to identify binary packages, but that tag gets inserted late in an actual package build, whereas we'd like to source headers to be identifiable right after spec parse already. Non-presence of a tag is not a very strong indicator anyhow, and even less so when said headers are still under construction.

Move RPMTAG_SOURCEHEADER insertion early - there's no reason not to - and use its presence as a positive identification of source headers, falling back to the "not a binary" logic when not there to preserve behavior otherwise.

And as for why not move SOURCERPM insertion earlier? There be dragons.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3012

-- Commit Summary --

  * Ensure source headers are identified as such after a spec parse

-- File Changes --

    M build/pack.c (2)
    M build/parseSpec.c (3)
    M lib/headerutil.c (4)
    M tests/rpmquery.at (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3012.patch
https://github.com/rpm-software-management/rpm/pull/3012.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3012
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3012 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240402/504dd4e3/attachment.html>