[Rpm-maint] [rpm-software-management/rpm] Move OpenSSL code to newer API (PR #2723)

Michael Schroeder notifications at github.com
Tue Apr 16 13:29:02 UTC 2024


I think you broke DSA signatures: it calls `EVP_PKEY_verify` with `padded_sig` which is constructed from just `sig->r`. But  `constructDSASignature` (called at the beginning) takes `sig->r` and `sig->s` and creates a DSA_SIG from it.

I'm pretty sure PKEY_verify to be passed something DER encoded instead...

We need a testcase for DSA signatures...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2723#issuecomment-2059096444
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2723/c2059096444 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240416/d9c3ec91/attachment.html>


More information about the Rpm-maint mailing list