[Rpm-maint] [rpm-software-management/rpm] Add prepend and append modes for all our normal build scriptlets (PR #2728)

Panu Matilainen notifications at github.com
Thu Apr 18 07:30:21 UTC 2024


@pmatilai commented on this pull request.



> @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main package.
 Package build is divided into multiple separate steps, each executed
 in a separate shell.
 
+Only one of each section can be present in a spec, but all build scriptlets
+except for `%prep` accept options `-a` and `-p`, for append and prepend mode.
+Append and prepend append or prepend lines to the section in the order they
+appear in the spec. Both append and prepend can be used multiple times and
+without other restrictions, but a section without either mode can only
+appear first (eg `%build` cannot follow `%build -p`).

Turns out what felt artificial, was in fact an artificial limit of the implementation. 
https://github.com/rpm-software-management/rpm/pull/3047 does away with that limitation, -a/-p are always applied relative to the main section if it exists, otherwise the first fragment is used as the base. Makes a lot more sense that way.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2728#discussion_r1570157804
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2728/review/2008073835 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240418/9b65080f/attachment-0001.html>


More information about the Rpm-maint mailing list