[Rpm-maint] [rpm-software-management/rpm] Pass arg3 to regular and file trigger scripts (PR #3018)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -248,4 +248,29 @@ char *argvJoin(ARGV_const_t argv, const char *sep)
 
     return dest;
 }
-    
+
+ARGV_t argvFromVaList(const char *fmt, va_list ap)
+{
+    ARGV_t argv = argvNew();

No need for argvNew(), argvAdd*() handles that as needed. Without this, an invalid fmt will return NULL which is what we probably want.

I think I'd also make this a private helper inside rpmscript.c, all of argv.* is considered deprecated going forward so maybe we shouldn't add more public APIs there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3018#pullrequestreview-2016536902
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3018/review/2016536902 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240423/3f95eaec/attachment.html>