[Rpm-maint] [rpm-software-management/rpm] Fix file handle leaks (PR #3068)

Florian Festi notifications at github.com
Mon Apr 29 15:58:02 UTC 2024


@ffesti commented on this pull request.



>  	return 1;
     }
 
     // We expect success now.
     char *got = rpmhex(fp, fplen);
     if (! got) {
 	fprintf(stderr, "%s: rpmhex failed\n", filename);
+	fclose(f);

This should probably also free(fp);

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3068#pullrequestreview-2028918055
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3068/review/2028918055 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240429/85749b0b/attachment.html>


More information about the Rpm-maint mailing list