[Rpm-maint] [rpm-software-management/rpm] Give better error message for dangerous symlinks (PR #3175)

Florian Festi notifications at github.com
Wed Aug 14 11:27:43 UTC 2024


> Looks much better.
> 
> I'd leave fsmOpenat() return value alone and instead add the rc as the last argument 'int *rcp' (args returning data are typically last in rpm), that should require fewer changes across the board.

Well, I modeled it after  `static int fsmOpen(int *wfdp, int dirfd, const char *dest)` to make the code more consistent. While the change might be a bit bigger, I think it's the better option. Also returning the fd and having the rc in the attrs seems weird to me.

Changed the error message, though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3175#issuecomment-2288495657
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3175/c2288495657 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240814/0c547386/attachment.html>


More information about the Rpm-maint mailing list