[Rpm-maint] [rpm-software-management/rpm] Restore --build-in-place with --noprep functionality (PR #3252)

[Panu Matilainen]

In rpm >= 4.20 we always have to have the build directory. Commit c74ab58f081937eefd0f79af8d0310495d321864 linked its creation to --noprep but that was under the assumption of normal builds where %prep has already been executed, and we're re-entering the already created directory structure for another build stage.

--build-in-place being what it is, there's basically nothing to do at %prep so it seems natural that this should work. The linux kernel upstream packaging uses this to allow quickly building "dirty" rpm from a git repo directly, but faciliate a full regular rpmbuild from an src.rpm built this way. It seems like a reasonable thing, in fact this makes me think that --build-in-place should imply skipping %prep, but lets not go there yet...

Make sure %mkbuilddir gets run if we execute any build steps, this is fairly subtle to preserve --short-circuit too.

Fixes: #3216
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3252

-- Commit Summary --

  * Restore --build-in-place with --noprep functionality

-- File Changes --

    M build/build.c (2)
    M tests/rpmbuild.at (21)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3252.patch
https://github.com/rpm-software-management/rpm/pull/3252.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3252
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3252 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240821/8c269559/attachment.html>