[Rpm-maint] [rpm-software-management/rpm] Allow to specify a default for bcond features in a macro file (PR #2405)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -2413,6 +2414,7 @@ runroot rpm -q --provides -p /build/RPMS/noarch/bcondtest-1.0-1.noarch.rpm |
 ],
 [])
 
+

Couple of unrelated empty lines getting added here and above, and also just before and between the new tests. It's a good idea to eyeball 'git diff' and/or 'git show' output for irregularities like this before pushing.

Other than that, looks fine to me now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2405#pullrequestreview-1871853838
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2405/review/1871853838 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240209/04f360c0/attachment-0001.html>