[Rpm-maint] [rpm-software-management/rpm] Drop erroneous BYPRODUCTS uses from the cmake files (PR #2900)

Panu Matilainen notifications at github.com
Tue Feb 13 07:43:59 UTC 2024


BYPRODUCTS is only relevant for Ninja generator which we officially don't even support, but on which these usages cause Ninja to error out with "phony target names itself as an input" messages.

I don't remember why exactly I put these BYPRODUCTS in there, but I know it was NOT to support Ninja explicitly. Probably it seemed somehow relevant to this cmake newbie and since it didn't harm anything ... on the make generator. Taking them out makes Ninja happy except for the test-suite. The make generator is still the only officially supported one though.

Reported-by: Timothy Brackett <brackett.tc at gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2900

-- Commit Summary --

  * Drop erroneous BYPRODUCTS uses from the cmake files

-- File Changes --

    M CMakeLists.txt (1)
    M tools/CMakeLists.txt (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2900.patch
https://github.com/rpm-software-management/rpm/pull/2900.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2900
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2900 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240212/f30a4d8a/attachment.html>


More information about the Rpm-maint mailing list