[Rpm-maint] [rpm-software-management/rpm] CMakeLists.txt: eliminate floating dependencies (PR #2914)

Alexander Kanavin notifications at github.com
Fri Feb 16 12:18:41 UTC 2024


Prior to this, the respective build options would get enabled depending on whether or not these components were found on the build system.

I believe it's better to make them strict (add REQUIRED parameter), so that rpm builds are always deterministic, subject to cmake options.

As a follow-up, some of these newly hardened dependencies can be wrapped in cmake options (like was just done for readline support), if there are situations where they should be disabled.

Resolves: https://github.com/rpm-software-management/rpm/issues/2855
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2914

-- Commit Summary --

  * CMakeLists.txt: eliminate floating dependencies

-- File Changes --

    M CMakeLists.txt (12)
    M docs/CMakeLists.txt (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2914.patch
https://github.com/rpm-software-management/rpm/pull/2914.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2914 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240216/89445c30/attachment.html>


More information about the Rpm-maint mailing list