[Rpm-maint] [rpm-software-management/rpm] No build directives in generated spec parts (PR #2917)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +		if (stage == GENERATED) {
+		    switch (tag) {
+		    case RPMTAG_SOURCE:
+		    case RPMTAG_PATCH:
+		    case RPMTAG_NOSOURCE:
+		    case RPMTAG_NOPATCH:
+		    case RPMTAG_EXCLUDEARCH:
+		    case RPMTAG_EXCLUSIVEARCH:
+		    case RPMTAG_EXCLUDEOS:
+		    case RPMTAG_EXCLUSIVEOS:
+		    case RPMTAG_BUILDROOT:
+		    case RPMTAG_BUILDCONFLICTS:
+		    case RPMTAG_BUILDOPTION:
+		    case RPMTAG_BUILDPREREQ:
+		    case RPMTAG_BUILDREQUIRES:
+		    case RPMTAG_BUILDSYSTEM:

Add this info to the struct in preambleList instead, that forces one to consider this issue whenever new tags are added.
You can check for this from findPreambleTag() just as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1890134783
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2917/review/1890134783 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240220/f8e1e583/attachment.html>