[Rpm-maint] [rpm-software-management/rpm] No build directives in generated spec parts (PR #2917)

Panu Matilainen notifications at github.com
Tue Feb 20 11:03:21 UTC 2024


@pmatilai commented on this pull request.



> @@ -21,6 +21,11 @@
 #define ALLOWED_CHARS_EVR ALLOWED_CHARS_VERREL "-:"
 #define LEN_AND_STR(_tag) (sizeof(_tag)-1), (_tag)
 
+enum parseStages {
+    SPECFILE,
+    BUILDSYS,
+    GENERATED,

Use some unique prefix on the enum names, makes it easier to grep for affected places, something like STAGE_FOO or PARSE_FOO.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1890141434
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2917/review/1890141434 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240220/ec6e7046/attachment.html>


More information about the Rpm-maint mailing list