[Rpm-maint] [rpm-software-management/rpm] Add --list-keys and --delete-key to rpmkeys (PR #2921)

Panu Matilainen notifications at github.com
Wed Feb 21 08:38:07 UTC 2024


@pmatilai commented on this pull request.



>      case MODE_LISTKEY:
+	if (args != NULL) {
+	    argerror(_("--list-keys does not take any arguments"));
+	}
+	ARGV_t query = argvSplitString("gpg-pubkey", " ", ARGV_NONE);

It's a bit creative way to initialize an argv... I think
```
ARGV_t query = NULL;
argvAdd(&query, "gpg-pubkey");
```
...would be a well worth the one extra line in obviousness :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2921#pullrequestreview-1892397084
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2921/review/1892397084 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240221/8a5a6869/attachment.html>


More information about the Rpm-maint mailing list