[Rpm-maint] [rpm-software-management/rpm] Set git commit dates based on $SOURCE_DATE_EPOCH (PR #2930)

[Panu Matilainen]

> SOURCE_DATE_EPOCH is exactly the field that should be used here. That variable says when the sources were last modified, so if we do a fake commit when unpacking the sources, this is the timestamp to use.

I totally agree that's the timestamp to use, it's just the means of getting the value I mildly disagree with.

I looked at https://reproducible-builds.org/specs/source-date-epoch/ a bit now, for the first time ever. Among other things, there's

> Build processes MUST use this variable for embedded timestamps in place of the "current" date and time. 

So if rpm is supposed to honor this spec, package buildtime MUST be set from SOURCE_DATE_EPOCH if its set. And from there, we get to the point that you can just use RPM_BUILD_TIME for any timestamps, you don't need to differentiate between the two.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2930#issuecomment-1968421934
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2930/c1968421934 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240227/947e5a17/attachment-0001.html>