[Rpm-maint] [rpm-software-management/rpm] No build directives in generated spec parts (PR #2917)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -1109,6 +1123,25 @@ static rpmRC parseSpecSection(rpmSpec *specptr, int secondary)
 	    goto errxit;
 	}
 
+	if (stage == PARSE_GENERATED) {
+	    switch (parsePart) {
+	    case PART_PREP:
+	    case PART_BUILD:
+	    case PART_INSTALL:
+	    case PART_CHECK:
+	    case PART_CLEAN: /* ???? */
+	    case PART_BUILDARCHITECTURES:
+	    case PART_PATCHLIST:
+	    case PART_SOURCELIST:
+	    case PART_BUILDREQUIRES:
+	    case PART_CONF:

Not sure if this was in the earlier version or I just missed it, but this info should go to struct PartRec for the same reason as the tags: to force people to consider the matter when adding new.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1905879453
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2917/review/1905879453 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240228/cbad59bc/attachment.html>