[Rpm-maint] [rpm-software-management/rpm] No build directives in generated spec parts (PR #2917)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -1060,71 +1069,72 @@ typedef const struct PreambleRec_s {
     int type;
     int deprecated;
     int ismacro;
+    int notgenerated;

"notgenerated" is not the greatest name ever :smile: 

Maybe "isgenerated" and just flip the meaning around? Other possibilities could be something around dynamic/static.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1905882276
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2917/review/1905882276 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240228/0e2a7d19/attachment.html>