[Rpm-maint] [rpm-software-management/rpm] Remove cycles from CMake dependency graph (PR #2820)

Panu Matilainen notifications at github.com
Tue Jan 9 09:00:52 UTC 2024


@pmatilai commented on this pull request.



> @@ -434,17 +434,17 @@ function(add_tarball targetname namever treeish)
 	set(distname ${tarname}.bz2)
 	set(docname ${namever}-doc.${distfmt})
 
-	add_custom_target(${docname}
-		DEPENDS man apidoc
+	file(GLOB man_pages docs/man/*.[1-8])

What's the reason for this? AFAICS the tarball gets updated on man page changes as it is, through the "man" target.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2820#pullrequestreview-1810685786
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2820/review/1810685786 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240109/7b125b4f/attachment.html>


More information about the Rpm-maint mailing list