[Rpm-maint] [rpm-software-management/rpm] Fix sinfoCmp to order signatures correctly (PR #3194)

[Panu Matilainen]

@pmatilai commented on this pull request.



>  	/* Take care not to override a previous failure with success */
-	if (res > vd->type[sinfo->type])
-	    vd->type[sinfo->type] = res;
+	if (severity > vd->type[sinfo->type]) {
+	    vd->type[sinfo->type] = severity;

Ehm, okay so vd->type is something entirely different (a field badly named by me), I first thought this was abusing the data contained in sinfo->type. This is more harmless but also there's nothing saved by avoiding an extra field for the purpose, this code is bad enough as it is :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3194#discussion_r1696765745
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3194/review/2207366018 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240730/ec9c6b9f/attachment.html>