[Rpm-maint] [rpm-software-management/rpm] Fix sinfoCmp to order signatures correctly (PR #3194)

[Panu Matilainen]

Other remarks found from the dusty archives while poking around this area in my head:

IIRC the reason the transaction verify reports the first issue found is that in that context, there's no point continuing. And so, you can just report the first error found. Or so the theory goes, clearly the existing code gets it wrong in the case of NOTFOUND encountered first which is more likely to happen with the sinfo sorting fixed. Makes me think the NOTFOUND handling is basically in the wrong place, the verify callback is not interested whether the signature is RSA or DSA or whatever, it just wants to know if there was a signature that we could verify. Which I think should really be hidden inside rpmvs. There's a Finnish idiom "juosten kustu", basically "peed while running" that seems appropriate for the existing signature callback mess - it's just the kind of thing you get when you're think you're in hurry and don't stop to think properly :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3194#issuecomment-2258147806
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3194/c2258147806 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240730/9e92dde6/attachment.html>