[Rpm-maint] [rpm-software-management/rpm] RPM 4.20.0 ALPHA2 (PR #3107)

soig notifications at github.com
Sat Jun 1 15:59:54 UTC 2024 

Le ven. 17 mai 2024 à 13:37, Michal Domonkos ***@***.***> a
écrit :

> Merged #3107 <https://github.com/rpm-software-management/rpm/pull/3107>
> into rpm-4.20.x.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/rpm-software-management/rpm/pull/3107#event-12846898308>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAXGVEIQAUGIDQRJCUCKQETZCXTXBAVCNFSM6AAAAABH34XQOWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA2DMOBZHAZTAOA>
> .
> You are receiving this because you are subscribed to this thread.
>

We are hitting 3 issues on Mageia with 4.20.x.
Note that we all those upstream patches have been backported:
0001-Ensure-noarch-packages-don-t-get-debuginfo.patch
0001-Fix-noprep-regression-from-introducing-mkbuilddir.patch
0002-Drop-an-accidentally-added-duplicated-test.patch
0003-Make-build-in-place-much-less-of-a-hack-and-also-wor.patch
0001-Fix-incomplete-header-on-plain-src.rpm-build-modes-r.patch
0001-Hammer-in-no-debuginfo-for-noarch-packages-damn-it-r.patch
0001-Fix-regression-on-subpackage-debuginfo-RPMTAG_SOURCE.patch

1) signatures being refused
This one seems to be on Mageia :
error: Verifying a signature using certificate
00EDB89585B012A8916F0DF8B742FA8B80420F66 (Mageia Packages <
***@***.***>):
  1. Certificiate B742FA8B80420F66 invalid: certificate is not alive
      because: The primary key is not live
      because: Expired on 2012-03-13T12:10:11Z
  2. Key B742FA8B80420F66 invalid: key is not alive
      because: The primary key is not live
      because: Expired on 2012-03-13T12:10:11Z

However this break "urpmi --no-verify" which used to behave like rpm
--no-verify
But now only rpm --nosignature can bypass this check, whereas rpm
--no-verify used to do the same, which looks like regression ?


2) this breaks perl-RPM4's testsuite:
See
https://gitweb.mageia.org/software/rpm/perl-RPM4/tree/RPM4/t/04spec.t#n57
This can be run with: cd RPM4; perl Makefile.PL; make && make test

With rpm-4.19:
ok 13 - simulate rpm -bp (check prep)
Executing(%build): /bin/sh -e /tmp/7ICL2x4Fnn/rpm-tmp.MpqXIY

With rpm-4.20:
+not ok 13 - simulate rpm -bp (check prep)
+#   Failed test 'simulate rpm -bp (check prep)'
+#   at t/04spec.t line 57.
+Executing(%build): /bin/sh -e /tmp/Cb7Sykk9CP/rpm-tmp.H778zX
+/tmp/Cb7Sykk9CP/rpm-tmp.H778zX: line 31: cd:
/tmp/Cb7Sykk9CP/test-rpm-1.0-build: No such file or directory
+error: Bad exit status from /tmp/Cb7Sykk9CP/rpm-tmp.H778zX (%build)

There's a regression here: it doesn' create the directory anymore.
Is this a rpm regression or does RPM4 needs to be adjusted?
Both builddir and topdir are absolute
The test spec file it loads is
https://gitweb.mageia.org/software/rpm/perl-RPM4/tree/RPM4/t/test-rpm.spec
I'd really like to have a feedback for this one.


3) urpmi testsuite fails b/o of missing debuginfo:
error: Empty %files file
/home/tv/mga/git/mga/urpmi/t/tmp/BUILD/a-1-build/debugsourcefiles.list
error: Empty %files file
/home/tv/mga/git/mga/urpmi/t/tmp/BUILD/b-1-build/debugsourcefiles.list
But it's silly to try to extract debuginfo when there's no
I could make those pkgs noarch or set debug_package to %{nil}
On second though I wonder why this wasn't an issue before ?

I fixed those ones in urpmi.
But then I'm hitting this one:
error: Bad exit status from /home/tv/mga/git/mga/urpmi/t/tmp/rpm-tmp.h09qUo
(%install)

#   Failed test 'rpmbuild --quiet --define '_topdir
/home/tv/mga/git/mga/urpmi/t/tmp' --define '_tmppath
/home/tv/mga/git/mga/urpmi/t/tmp' -bb --clean --nodeps  --define
'__os_install_post %nil' --define 'rpm_version %(rpm -q --queryformat
"%{VERSION}" rpm|sed -e "s/\\.//g")'  data/SPECS/buildroot_default.spec'
will

This can be reproduced by running:
rpmbuild   -bb --clean  t/data/SPECS/buildroot_default.spec
I've attached the rpmbuild output for both 4.19 & 4.20 which shows the
regression

Compare:

rpm-4.19.1.1:
$ rpm --eval %buildroot
/home/tv/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64

rpm-4.19.91:
$ rpm --eval %buildroot
%buildroot

I just saw commit 0310a233b953c015bd17ecfbb0e558ceaf071fc7 (" Fix a
%buildroot regression on an early %__spec_install_pre %global override"),
I'll try again with that commit backported, even though the context is
different as it happens quite a lot later, at the end of the build process.

See you

Message ID: <rpm-software-management/rpm/pull/3107/issue_event/12846898308@
> github.com>
>

$ LC_ALL=C rpmbuild   -bb --clean  t/data/SPECS/buildroot_default.spec
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.DxJCOX
+ umask 022
+ cd /home/tv/rpmbuild/BUILD
+ '[' 1 -eq 1 ']'
+ '[' /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 '!=' / ']'
+ rm -rf /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
++ dirname /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ mkdir -p /home/tv/rpmbuild/BUILDROOT
+ mkdir /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ '[' 1 -eq 1 ']'
++ echo /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
++ sed 's!//!/!'
+ wanted=/home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ echo 'buildroot should be /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64'
buildroot should be /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ '[' /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 = /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 ']'
+ '[' /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 = /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 ']'
++ echo /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ '[' /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 = /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64 ']'
+ mkdir -p /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64/etc
+ echo foo
+ /usr/lib/rpm/check-buildroot
+ '[' -n '' ']'
+ /usr/share/spec-helper/clean_files
+ '[' -n '' ']'
+ /usr/share/spec-helper/compress_files .xz
+ '[' -n '' ']'
+ /usr/share/spec-helper/relink_symlinks
+ '[' -n '' ']'
+ /usr/share/spec-helper/clean_perl
+ '[' -n '' ']'
+ /usr/share/spec-helper/lib_symlinks
+ '[' -n '' ']'
+ /usr/share/spec-helper/gprintify
+ '[' -n '' ']'
+ /usr/share/spec-helper/fix_mo
+ '[' -n '' ']'
+ /usr/share/spec-helper/fix_pamd
+ '[' -n '' ']'
+ /usr/share/spec-helper/remove_info_dir
+ '[' -n '' ']'
+ /usr/share/spec-helper/fix_eol
+ '[' -n '' ']'
+ /usr/share/spec-helper/check_desktop_files
+ '[' -n '' ']'
+ /usr/share/spec-helper/check_elf_files
+ /usr/lib/rpm/brp-strip /usr/bin/strip
+ /usr/lib/rpm/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/check-rpaths
+ /usr/lib/rpm/brp-remove-la-files
+ /usr/lib/rpm/redhat/brp-mangle-shebangs
+ env -u SOURCE_DATE_EPOCH /usr/lib/rpm/redhat/brp-python-bytecompile '' 1 0 -j8
+ /usr/lib/rpm/redhat/brp-python-hardlink
Processing files: buildroot-1-1.x86_64
Provides: buildroot = 1-1 buildroot(x86-64) = 1-1
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
Wrote: /home/tv/rpmbuild/RPMS/x86_64/buildroot-1-1.x86_64.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.ic66NI
+ umask 022
+ cd /home/tv/rpmbuild/BUILD
+ /usr/bin/rm -rf /home/tv/rpmbuild/BUILDROOT/buildroot-1-1.x86_64
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(rmbuild): /bin/sh -e /var/tmp/rpm-tmp.VAy57Q
+ umask 022
+ cd /home/tv/rpmbuild/BUILD
+ rm -rf '/home/tv/rpmbuild/BUILD/%{buildsubdir}-SPECPARTS'
+ RPM_EC=0
++ jobs -p
+ exit 0

$ LC_ALL=C rpmbuild   -bb --clean  t/data/SPECS/buildroot_default.spec
Executing(%mkbuilddir): /bin/sh -e /var/tmp/rpm-tmp.JMrjIu
+ umask 022
+ cd /home/tv/rpmbuild/BUILD/buildroot-1-build
+ test -d /home/tv/rpmbuild/BUILD/buildroot-1-build
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w /home/tv/rpmbuild/BUILD/buildroot-1-build
+ /usr/bin/rm -rf /home/tv/rpmbuild/BUILD/buildroot-1-build
+ /usr/bin/mkdir -p /home/tv/rpmbuild/BUILD/buildroot-1-build
+ /usr/bin/mkdir -p /home/tv/rpmbuild/BUILD/buildroot-1-build/SPECPARTS
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.1a2BZR
+ umask 022
+ cd /home/tv/rpmbuild/BUILD/buildroot-1-build
+ '[' 1 -eq 1 ']'
+ '[' /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT '!=' / ']'
+ rm -rf /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT
++ dirname /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT
+ mkdir -p /home/tv/rpmbuild/BUILD/buildroot-1-build
+ mkdir /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT
+ '[' 1 -eq 1 ']'
++ echo '%{_buildrootdir}/buildroot-1-1.x86_64'
++ sed 's!//!/!'
+ wanted='%{_buildrootdir}/buildroot-1-1.x86_64'
+ echo 'buildroot should be %{_buildrootdir}/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT'
buildroot should be %{_buildrootdir}/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT
+ '[' /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT = '%{_buildrootdir}/buildroot-1-1.x86_64' ']'
+ echo 'buildroot should be %{_buildrootdir}/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT'
buildroot should be %{_buildrootdir}/buildroot-1-1.x86_64 instead of /home/tv/rpmbuild/BUILD/buildroot-1-build/BUILDROOT
+ exit 1
error: Bad exit status from /var/tmp/rpm-tmp.1a2BZR (%install)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.1a2BZR (%install)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3107#issuecomment-2143496909
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3107/c2143496909 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240601/2b35b854/attachment-0001.html>

More information about the Rpm-maint mailing list