[Rpm-maint] [rpm-software-management/rpm] Minimally bring back --buildroot and %{_buildrootdir} (PR #3139)

[Panu Matilainen]

Originally reported at https://bugzilla.redhat.com/show_bug.cgi?id=2284124:

cpack RPM generator uses --buildroot, which we axed in 9d35c8df497534e1fbd806a4dc78802bcf35d7cb a little too eagerly. We can't just break cpack so bring it back until cpack moves to something else.

On a related finding (@soig ), various specs use %{_buildrootdir} in ways that they really shouldn't, but since compatibility is cheap, we can bring it back but define it on our own terms: it's simply always the parent directory of %{buildroot}, rather than the other way around of %{buildroot} being a subdirectory of %{_buildrootdir}.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3139

-- Commit Summary --

  * Minimally bring back --buildroot cli switch for cpack
  * Minimally bring back %{_buildrootdir} for backwards compatibility

-- File Changes --

    M build/parsePreamble.c (24)
    M build/parseSpec.c (12)
    M docs/man/rpmbuild.8.md (7)
    M include/rpm/rpmbuild.h (2)
    M tests/rpmbuild.at (25)
    M tools/rpmbuild.c (10)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3139.patch
https://github.com/rpm-software-management/rpm/pull/3139.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3139
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3139 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240603/d7ae8f8e/attachment.html>