[Rpm-maint] [rpm-software-management/rpm] rpm 4.20.0 alpha fallout #3 : urpmi's testsuite is broken by new rpm (%buildroot no more defined) (Issue #3144)

[soig]

We are hitting issues on Mageia with 4.20.x.
The new alpha breaks urpmi's testsuite b/c of missing debuginfo:

> error: Empty %files file /home/tv/mga/git/mga/urpmi/t/tmp/BUILD/a-1-build/debugsourcefiles.list
> error: Empty %files file /home/tv/mga/git/mga/urpmi/t/tmp/BUILD/b-1-build/debugsourcefiles.list

But it's silly to try to extract debuginfo when there's no
I could make those pkgs noarch or set debug_package to %{nil}
On second though I wonder why this wasn't an issue before ?

I fixed those ones in urpmi.

But then I'm hitting this one:

> error: Bad exit status from /home/tv/mga/git/mga/urpmi/t/tmp/rpm-tmp.h09qUo (%install)
> 
> #   Failed test 'rpmbuild --quiet --define '_topdir /home/tv/mga/git/mga/urpmi/t/tmp' --define '_tmppath /home/tv/mga/git/mga/urpmi/t/tmp' -bb --clean --nodeps  --define '__os_install_post %nil' --define 'rpm_version %(rpm -q --queryformat "%{VERSION}" rpm|sed -e "s/\\.//g")'  data/SPECS/buildroot_default.spec'


This can be reproduced by running:
`rpmbuild   -bb --clean  t/data/SPECS/buildroot_default.spec`
(with https://gitweb.mageia.org/software/rpm/urpmi/tree/t/data/SPECS/buildroot_default.spec)
I've attached the rpmbuild output for both 4.19 & 4.20 which shows the regression
The issue is that the _buildrootdir macro disappeared in  commit 9d35c8df497534e1fbd806a4dc78802bcf35d7cb

Compare:

- rpm-4.19.1.1:
> $ rpm --eval %buildroot
> /home/tv/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64

- rpm-4.19.91:
> $ rpm --eval %buildroot
> %buildroot

I can drop the test but I'm pretty sure the cople macros that were removed will explode quite a lot of spec files in the wild…

Note that we all those upstream patches have been backported:
0001-Ensure-noarch-packages-don-t-get-debuginfo.patch
0001-Fix-noprep-regression-from-introducing-mkbuilddir.patch
0002-Drop-an-accidentally-added-duplicated-test.patch
0003-Make-build-in-place-much-less-of-a-hack-and-also-wor.patch
0001-Fix-incomplete-header-on-plain-src.rpm-build-modes-r.patch
0001-Hammer-in-no-debuginfo-for-noarch-packages-damn-it-r.patch
0001-Fix-regression-on-subpackage-debuginfo-RPMTAG_SOURCE.patch
0001-Fix-a-buildroot-regression-on-an-early-__spec_instal.patch

[buildroot-rpm-4.20.txt](https://github.com/user-attachments/files/15545814/buildroot-rpm-4.20.txt)
[buildroot-rpm-4.19.txt](https://github.com/user-attachments/files/15545816/buildroot-rpm-4.19.txt)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3144
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/3144 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240604/d255a70d/attachment.html>