[Rpm-maint] [rpm-software-management/rpm] Check for mandatory tags after parsing the Spec the first time (PR #3158)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -2961,6 +2961,7 @@ RPMTEST_CLEANUP
 # Check if dynamic spec generation works for main package, too
 AT_SETUP([rpmbuild with dynamic spec generation for main package])
 AT_KEYWORDS([build])
+AT_XFAIL_IF([test $RPM_XFAIL -ne 0])

AT_XFAIL_IF indicates a known bug, so AIUI it shouldn't be used here. When testing for bad input, just expect the failure code (and error messages) in the test directly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3158#pullrequestreview-2110225201
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3158/review/2110225201 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240611/40e08243/attachment.html>