[Rpm-maint] [rpm-software-management/rpm] Check for mandatory tags after parsing the Spec the first time (PR #3158)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -2983,6 +2986,24 @@ runroot rpm -ql /build/RPMS/noarch/dynamic-docs-1.0-1.noarch.rpm
 [])
 RPMTEST_CLEANUP
 
+# ------------------------------
+# Check if dynamic spec generation works for main package, too
+# Check for failure as feature is disabled. Remove test when enabled
+AT_SETUP([rpmbuild with dynamic spec generation for main package])
+AT_KEYWORDS([build])
+RPMDB_INIT
+RPMTEST_CHECK([
+
+runroot rpmbuild --define "_prefix /usr/local" -D "FULLDYNAMIC 1" -ba /data/SPECS/dynamic.spec

But this is still testing -ba which wasn't the problem to begin with, -bs is:

> rpmbuild -D "FULLDYNAMIC 1" -bs ../tests/data/SPECS/dynamic.spec; echo $?
[...]
error: Summary field must be present in package: dynamic
error: License field must be present in package: dynamic
Wrote: /home/pmatilai/rpmbuild/SRPMS/dynamic-1.0-1.src.rpm
0

This patch does fix that, but test for it too. The cost here is disabling the previously working -ba case but if this is the best we can do then it's the best we can do.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3158#pullrequestreview-2112660371
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3158/review/2112660371 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240612/02dcaacb/attachment-0001.html>