[Rpm-maint] [rpm-software-management/rpm] Check for mandatory tags after parsing the Spec the first time (PR #3158)

[Florian Festi]

@ffesti commented on this pull request.



> @@ -2983,6 +2986,24 @@ runroot rpm -ql /build/RPMS/noarch/dynamic-docs-1.0-1.noarch.rpm
 [])
 RPMTEST_CLEANUP
 
+# ------------------------------
+# Check if dynamic spec generation works for main package, too
+# Check for failure as feature is disabled. Remove test when enabled
+AT_SETUP([rpmbuild with dynamic spec generation for main package])
+AT_KEYWORDS([build])
+RPMDB_INIT
+RPMTEST_CHECK([
+
+runroot rpmbuild --define "_prefix /usr/local" -D "FULLDYNAMIC 1" -ba /data/SPECS/dynamic.spec

Well, the -ba thing no longer working is very much on purpose and not an unwanted side effect. We want a spec file to either be legal and producing binary and source packages or it to fail - no matter what operation one tries. As this now fails at the parse stage -bs and -ba don't make a difference. But I can run the same test with -bs, too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3158#discussion_r1636318574
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3158/review/2112781844 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240612/647c1931/attachment.html>