[Rpm-maint] [rpm-software-management/rpm] Check for mandatory tags after parsing the Spec the first time (PR #3158)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -2983,6 +2986,24 @@ runroot rpm -ql /build/RPMS/noarch/dynamic-docs-1.0-1.noarch.rpm
 [])
 RPMTEST_CLEANUP
 
+# ------------------------------
+# Check if dynamic spec generation works for main package, too
+# Check for failure as feature is disabled. Remove test when enabled
+AT_SETUP([rpmbuild with dynamic spec generation for main package])
+AT_KEYWORDS([build])
+RPMDB_INIT
+RPMTEST_CHECK([
+
+runroot rpmbuild --define "_prefix /usr/local" -D "FULLDYNAMIC 1" -ba /data/SPECS/dynamic.spec

My point is that -bs cannot like ever work on a highly dynamic package where you just have to run the build to get the results, whereas -ba *could* work (if rpmbuild internals permit :smile: ). So it's useful to separate the cases.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3158#discussion_r1636335565
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3158/review/2112810969 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240612/adc40a7d/attachment-0001.html>